lightwalletd icon indicating copy to clipboard operation
lightwalletd copied to clipboard

Hardcoded go OS variable in makefile build instructions

Open lindanlee opened this issue 4 years ago • 2 comments

Makefile for darksidewalletd has a build_rel instruction with the GOOS hard coded as linux (I'm on the defuse/lightwalletd/darksidewallet-old):

image

Ideally this should be changed to an environment variable to match the current system's OS.

However, we're not really sure if what build_rel does, and I didn't have an issue building on mac because it runs build and not build_rel if build was run: image

lindanlee avatar Apr 14 '20 19:04 lindanlee

This is my sloppy work from a few months ago, apologies.

The build target was intended for devs and such.

The build_rel target was intended to be for build_release , with proper GOOS and GOARCH params. It would allow CI/CD to call these targets and ensure the output of the expected versioned binary is consistent.

As of now we default to Linux OS. Do we have requirements around target OS and target platform?

mdr0id avatar Apr 14 '20 22:04 mdr0id

For production deployment I think we only need x86_64 Linux. But we want it to build for devs on Mac (#229 is one blocker to that).

defuse avatar May 01 '20 05:05 defuse