lightwalletd
lightwalletd copied to clipboard
Hardcoded go OS variable in makefile build instructions
Makefile for darksidewalletd has a build_rel instruction with the GOOS hard coded as linux (I'm on the defuse/lightwalletd/darksidewallet-old):
Ideally this should be changed to an environment variable to match the current system's OS.
However, we're not really sure if what build_rel does, and I didn't have an issue building on mac because it runs build and not build_rel if build was run:
This is my sloppy work from a few months ago, apologies.
The build
target was intended for devs and such.
The build_rel
target was intended to be for build_release
, with proper GOOS
and GOARCH
params. It would allow CI/CD to call these targets and ensure the output of the expected versioned binary is consistent.
As of now we default to Linux OS. Do we have requirements around target OS and target platform?
For production deployment I think we only need x86_64 Linux. But we want it to build for devs on Mac (#229 is one blocker to that).