librustzcash
librustzcash copied to clipboard
zcash
Rust-language assets for Zcash
If a wallet has both Sapling and Orchard notes to use in a transaction, and is able to use the individual pools' notes to pay the necessary Sapling and Orchard...
`zcash_client_backend::data_api::wallet::{propose_shielding, shield_transparent_funds}` take a slice of transparent receivers that is used to filter the UTXOs that will be shielded: https://github.com/zcash/librustzcash/blob/5ed788dc79f7a4886996951f472203522011eebc/zcash_client_backend/src/data_api/wallet/input_selection.rs#L520-L528 These transparent inputs are then proposed to be spent in...
@str4d requested a number of changes similar to the following in #1202; these are being deferred until after #1195 to avoid severe rebase issues. > Minor nit: `vks` is passed...
``` thread 'zip321::tests::prop_zip321_roundtrip_request' panicked at 'called `Result::unwrap()` on an `Err` value: ParseError("Parsing Error: Error { input: \"&req-Z--+H4S-a-6+n.8303=%F0%9E%80%A1u7Jg%EF%BF%8CkdV%F0%90%96%BCf&t-5sC+v+LvTT-4DBbpf.8303=(*%F0%9E%B8%A1h%EC%8E%A1%F0%91%A3%BF1%F0%9E%B9%A4%E0%AB%AC%EF%BF%BD%26%C8%BA%EF%BF%97%E0%A1%A8%7B%F0%9F%95%B4%25%F0%91%8D%90f%E0%BA%870%EF%BF%BD..&address.8451=ztestsapling1r7j0ntzmyyjr6rcahn53pqzqa50zvs35c30dpuj0al7pact2n6ms8ageztadl630rrz72lugz54&amount.8451=20650450.32967&label.8451=%5C%E0%AF%97j%F0%9E%B9%99U%C2%A5%F0%9D%8D%AE%5Ba%F0%91%8D%90&message.8451=p%25*%E0%A9%AC:%25t%F0%9D%91%8F%2F%5Dv%E0%AC%B7%E1%A4%B1.%3D&address.8914=tmNS3TnDepuFBwiHAbvE25yaaRGmbp6ei9b&amount.8914=7816285.91354637&Lp2+49E4o2+-eRHVj4FR.8914=%5C%C2%A6:%5B%E0%B6%A0q%25%EF%BF%BDz%5C%232%5CD%EF%B9%8D%E0%A7%A7p%F0%9F%95%B4%F0%90%A6%BC%F0%92%91%B0%F0%90%AC%AB%F0%90%84%94&P--++Zp+73nL+-+t8V+R-c-U-.8914=%2F%C8%BA%22%EF%BF%BD%2F.%7B%F0%9E%BA%85%E0%B3%A3%F0%9A%BF%B9%F0%91%A4%B7:%F0%91%8D%87%C3%9C&address.9561=ztestsapling1garfq6xgcsehyv42z7zqjftva0gpu8kwc9765py274576ed65avmq9cw52ljhll8xhpkqkyae2l&amount.9561=61342.04030866&memo.9561=jv39Kr8-pcdjrlEkAOFSI27Zi0H_gDu7VcMEyqXWHPbEt7Fb&label.9561=amG%F0%9F%80%94%DF%85%D1%A8m%F0%91%8A%82%5D%E1%BF%8D*%25%E1%BD%99B%3F%26%E1%8A%8DD%60&UNpO8f3.9561=d%5C%E1%89%B8%E0%AE%AA%26%F0%90%A4%97D%E0%A1%9E%2F%25%F0%96%AD%9F%E0%B5%9B%F0%92%BF%A4f%F0%9E%B1%BCE1%F0%90%87%98%F0%92%93%82%E0%A8%AF\", code: Eof }")', zcash_client_backend/src/zip321.rs:1138:84 718 note: run with `RUST_BACKTRACE=1` environment variable to display...
AFAICT 22ed9ebd352c4d60cd4f882eb6644b07a1de1a9d was the only commit that didn't affect any existing test. We then altered its behaviour in 33be548f082ea9e8085b96ddb2a9733fc2e87f2b to match ZIP 316. We should have a test case covering...
> This is ignoring the `_sources` parameter to `select_spendable_notes`, and always selecting from both pools. It happens to cause no bugs because `zcash_client_backend` hard-codes both pools as sources if the...
`truncate_to_height` removes chain-related wallet data _above_ the given `block_height`. The trees are truncated to the state as of that height, but the checkpoint at that height is removed: https://github.com/zcash/librustzcash/blob/3dcac7a5ff11821c77f0c50a3a86c63cd27193da/zcash_client_sqlite/src/wallet.rs#L1908-L1914 This...
``` $ cargo check --all-targets --no-default-features [...] error[E0432]: unresolved imports `maybe_rayon::prelude::IndexedParallelIterator`, `maybe_rayon::slice::ParallelSliceMut` --> zcash_client_sqlite/src/lib.rs:37:15 | 37 | prelude::{IndexedParallelIterator, ParallelIterator}, | ^^^^^^^^^^^^^^^^^^^^^^^ no `IndexedParallelIterator` in `prelude` 38 | slice::ParallelSliceMut, | ^^^^^^^^^^^^^^^^^^^^^^^...
Some migrations require a seed phrase. Currently we have two: - UFVK support: seed required to derive the Orchard FVK component for each (derived) account. - Account ID changes: seed...
>The complete solution here would be something like: >* Add a method to `WalletRead` that is something like `detect_funding_accounts` that checks whether any of the wallet's accounts contributed value to...