librustzcash

librustzcash copied to clipboard

Add a BlockSource implementation that reads blocks from files in the filesystem.

1

Also, this adds functionality to create and insert records into the block metadata db that is used as the source for which blocks to read.

nuttycom

This currently takes $O(m \cdot n)$ time where m is the number of notes in the wallet, and n is the number of nullifiers in blocks. It should take $O(q...

daira

Add an explicit check for unspent transparent outputs whenever running initialization with a version of the zcash_client_sqlite library *not* compiled with the `transparent-inputs` feature flag, and fail if any are...

nuttycom

`blocks.hash` should be indexed I think. Actually it should maybe be UNIQUE, since zcashd pervasively assumes block hashes are unique. _Originally posted by @daira in https://github.com/zcash/librustzcash/pull/600#discussion_r946168618_

nuttycom

For example, set `RUST_BACKTRACE=1` in CI.

daira

Add orchard bundle creation to `zcash_primitives::transaction::builder::Builder`

7

I've marked this as draft, due to an issue with the selection of the orchard anchor. In Sapling, the anchor is only used in the creation of the spends. For...

AloeareV

Label Consensus Rules

1

defuse

This reminds me that we need to ensure that we handle search for the child 0 "diversified" transparent address correctly even when the Sapling default address is at a different...

nuttycom

This string matching is a bit ugly; can `UnifiedFullViewingKey::decode` return an enum for its error type instead? _Originally posted by @nuttycom in https://github.com/zcash/zcash-android-wallet-sdk/pull/530#discussion_r902009347_

nuttycom

Change the cache DB format for `zcash_client_sqlite`

2

Currently we store compact blocks in rows of a SQLite table (specifically `(height, blockbytes)`), in a database specifically for caching. @ccjernigan noted that this is quite inefficient when the compact...

str4d