sysinfo icon indicating copy to clipboard operation
sysinfo copied to clipboard

add detailed decode for separed memories

Open Haraguroicha opened this issue 5 years ago • 4 comments

There are only accept the first meet of memory type and speed, but there may have two or more different kind of memories installed into system at same time but there can not describe it.

So I add a Memories property to store the memory detailed information (I only pick some general use fields to decode)

Haraguroicha avatar Apr 30 '19 10:04 Haraguroicha

Hello @Haraguroicha and thanks for your contribution!

Still not much time to work on this properly, but at least I gave it a quick compile to see how it looks.

But, tested on 2 different machines, I just get panic: runtime error: slice bounds out of range

So, it will need more work and testing before I could merge it.

zcalusic avatar May 02 '19 21:05 zcalusic

Hi @zcalusic , thank for your response, I think I will test on more machine as I can and push addition patch to this PR.

Haraguroicha avatar May 13 '19 08:05 Haraguroicha

Hi @zcalusic, I think I can't reproduce the panic: runtime error: slice bounds out of range in Dell OptiPlex 7060 and ThinkPad X1 Carbon, it might the DMI data looks different between yours hardware environment and mine, could you please paste the trace log for this PR, and I will push addition patch to prevent it happened again, thanks.

Haraguroicha avatar May 30 '19 06:05 Haraguroicha

Hi @zcalusic, I think I can't reproduce the panic: runtime error: slice bounds out of range in Dell OptiPlex 7060 and ThinkPad X1 Carbon, it might the DMI data looks different between yours hardware environment and mine, could you please paste the trace log for this PR, and I will push addition patch to prevent it happened again, thanks.

try virtual machine; my virtual machine also has this issue

Hi @zcalusic, I think I can't reproduce the panic: runtime error: slice bounds out of range in Dell OptiPlex 7060 and ThinkPad X1 Carbon, it might the DMI data looks different between yours hardware environment and mine, could you please paste the trace log for this PR, and I will push addition patch to prevent it happened again, thanks.

try virtual machine; my virtual machine also has this issue

azvs avatar Jul 09 '19 09:07 azvs