osmapp icon indicating copy to clipboard operation
osmapp copied to clipboard

Layer index

Open Dlurak opened this issue 1 year ago • 6 comments

Integrate the layer index.

When adding a new layer a dialog opens where the user can select a layer:

image

In the next step the user is presented with some details like the description of the layer, here they also need to specify some parts of the url:

image

grafik

Todo:

  • [ ] Allow for overlays (Probably in a follow up pr)
  • [x] There is a best attribute to a layer to indicate if it is the best source for an area, maybe show these with a star icon in the selector
  • [x] Max/Min Zoom
  • [x] Geographic limitations
  • [x] Attributions

Dlurak avatar Apr 14 '24 15:04 Dlurak

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
osmapp ✅ Ready (Inspect) Visit Preview Sep 4, 2024 4:29pm

vercel[bot] avatar Apr 14 '24 15:04 vercel[bot]

Actually the idea for the layer index is yours. (See issue #232)

Dlurak avatar Apr 15 '24 11:04 Dlurak

@Dlurak is attempting to deploy a commit to the OsmAPP Team Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 19 '24 10:06 vercel[bot]

While playing around with different layers I noticed this bug:

The Northern German west coast tidalflats (infared) layer has this url: https://imagico.de/map/osmim_tiles.php?layer=LC81960222015233LGN00ir&z={z}&x={x}&y={-y}. It seems like {-y} is not supported. Any idea how we could deal with this problem?

Dlurak avatar Jun 19 '24 22:06 Dlurak

@zbycz I think it should be fine now

Dlurak avatar Jun 20 '24 19:06 Dlurak

The Northern German west coast tidalflats (infared) layer has this url: https://imagico.de/map/osmim_tiles.php?layer=LC81960222015233LGN00ir&z={z}&x={x}&y={-y}. It seems like {-y} is not supported. Any idea how we could deal with this problem?

@dlurak I think we should show warning in such cases and not allow the user to save the layer.

zbycz avatar Jun 22 '24 14:06 zbycz

Another problem that just occurred to me: The user may have custom layers in local storage that aren't compatible with the new system from this PR. I guess the simplest and safest solution would be to simply use a different key for local storage. What do you think?

Dlurak avatar Sep 03 '24 16:09 Dlurak

@zbycz I think it should be fine now

Dlurak avatar Sep 04 '24 09:09 Dlurak

Yo! Thats a pretty good job on everything. 👍 🥇 💯

Merging right now! I am so happy to have this finished. I already heard some complains about outdated layers in OsmAPP on the OSM Discord, this will probably make many people happy. 🙂

zbycz avatar Sep 04 '24 16:09 zbycz