Zach Birenbaum

Results 119 comments of Zach Birenbaum

> Do you think it's worth looking up the existing sign definition for backward compatibility? Currently users can override the sign definition to customize the display, this will no longer...

> > to combine the sign handler into the virtualtext handler, since the virtualtext is already using extmarks, and the signs could just be added in the same iteration of...

I think this is ready for review again. I am so sorry for all the review requests sent, didn't realize asking for one cancels another. Usually on the other side...

I think I covered everything that came up in the review comments, and I tested all the functions and they seem to be working well. I also ran scripts/gen_vimdoc.py so...

> I probably don't have time to work on this until next weekend. If anyone want's to take over feel free to do so! > > > > Still missing:...

edit: ignore everything I posted before about semantic_tokens_full. I now cant reproduce the issue myself on one of my devices. I know I didn't make any technical mistakes but believe...

This is configurable in your cmp config. Unlike other completion sources, copilot can use other lines above or below an empty line to provide a completion. I don't like the...

> This didn't work for me... I'm having the same behavior Are you entering the menu when you try to tab or it is just showing up?

Is this still a problem? I haven't had any issues with it or been able to reproduce it after using the above snippet.

> Unfortunately yes. The snippet didn't work for me. Can you supply your full cmp config?