Zac Bentley

Results 72 comments of Zac Bentley

@RonaldinhoL the issue has to do with when destructors are run. Python garbage collects things (and runs their destructors) when the reference count of an object drops to zero. If...

Any chance of a fix here, or would you accept PRs for this? Seems pretty bad.

What are the chances of this or #153 making it into the next release of pytest-asyncio? No problem either way; if it's unlikely we'll publish a wheel of one of...

That seems reasonable, thanks for the quick reply! I've observed the failures on the versions of RabbitMQ I've used. I was mostly after documentation so that I and others can...

**WIP notes**: the segfault is fixed as expected, but threads now leak if the log level's low enough to result in at least one call to the Python logger's `_log`...

WIP update: - Fixed thread leak by setting `logThreads` to `False` inside the C++ code, which should prevent thread-switching by the Python interpreter. I might be wrong about that, but...

~Assistance requested from a maintainer: the license check is failing, but I didn't add any new files. How can I tell what files it would like me to add a...

Any update on this? To my knowledge it should be mergeable.

@BewareMyPower fixing that test is proving troublesome. Something happening in the destructor is corrupting the python interpreter state and causing that test to fail. The failure's not a testing issue...

@BewareMyPower I redid some of this work and pulled more logging related logic into pure Python, which is now passed as a callback function into the C++ code. That ends...