Zafer Balkan

Results 181 comments of Zafer Balkan

Hi @df-an, Great catch. I'm on mobile so cannot test locally. Can you try giving the Sysnative full path for PowerShell? Something like `C:\Windows\Sysnative\WindowsPowerShell\v1.0\powershell.exe`?

Do you have any sample code for this to reproduce? Or do you want us to write two demo applications for the said dotnet versions to investigate it?

The same changes are proposed for the Wazuh 5.x agent as well in a [separate PR](https://github.com/wazuh/wazuh-agent/pull/180).

I don't know the percentages of users depending on the alphabet. But FIM currently works only for English alphabet. Any other users of Wazuh who use on non-English language systems...

Below is the breakdown of the UTF-8 characters based on acceptance. # Before | Byte Sequence | Valid Unicode Range | Byte Length | Status | Related Macro | Comments...

Improved unit tests based on the edge cases. # UTF-8 Validation Test Coverage Matrix | Test Case | Valid/Invalid | Covered Case | |----------------------------------------|---------------|-----------------------------------------------------------| | `test_valid_utf8_sequences` | Valid | ASCII,...

# UTF-8 Validation Test Coverage Matrix | Test Case | Valid/Invalid | Covered Case | |--------------------------------------------|---------------|-----------------------------------------------------------------| | `test_valid_utf8_sequences` | Valid | ASCII, 2-byte, 3-byte, 4-byte, complex scripts | | `test_invalid_utf8_sequences`...

While this PR attempts to improve the existing solution, it is better to use https://github.com/simdutf/is_utf8 for this task.

To put it simply, the current check is ISO/IEC 8859-1 check, not UTF-8.

Yes, I tried those test by writing a custom Python application, and then pasted the existing test but obviously the environment and conditions differ. Also, I combined all test in...