vvvv.js icon indicating copy to clipboard operation
vvvv.js copied to clipboard

add nodes

Open noobusdeer opened this issue 10 years ago • 4 comments

Add some nodes CAR CDR DeleteSlice Reader GetSlice GetSpread Advanced Sort Advanced Unzip Occurrence

noobusdeer avatar Aug 07 '14 04:08 noobusdeer

Thanks for this huge contribution, and sorry, that it took me so long to respond.

I suspect the QuerySelector node adds redundant functionality: you can already retreive DOM data by an ID by creating an input IOBox and labelling it with "#id" (where you replace "id" with the actual id, obviously). Like described in the "Reading from the DOM" section of the VVVV.js Integration Guide.

Or maybe I missed something? Correct me if I'm wrong.

zauner avatar Aug 19 '14 08:08 zauner

Yes, I use query selector to retrive information from dom elements, but I need to know from select element which is selected. I'm on holidays in spain so I can't answer fast)

On Tue, Aug 19, 2014 at 10:36 AM, Matthias Zauner [email protected] wrote:

Thanks for this huge contribution, and sorry, that it took me so long to respond. I suspect the QuerySelector node adds redundant functionality: you can already retreive DOM data by an ID by creating an input IOBox and labelling it with "#id" (where you replace "id" with the actual id, obviously). Like described in the "Reading from the DOM" section of the VVVV.js Integration Guide.

Or maybe I missed something? Correct me if I'm wrong.

Reply to this email directly or view it on GitHub: https://github.com/zauner/vvvv.js/pull/16#issuecomment-52604842

noobusdeer avatar Aug 19 '14 18:08 noobusdeer

Hi, im returned from holidays. QuerySelector used for selectIndex from select with js. I also have bugfix of my nodes in my fork so i can't understand how update my pull request.

noobusdeer avatar Aug 29 '14 07:08 noobusdeer

Hi, I was away from VVVV.js for a while, but back now :)

Ok, I'm pretty sure, QuerySelector does the same as named IOBoxes do, described in the VVVV.js Integration Guide. For example, you can get the selected option of a select box by naming an input IOBox like #select-box-id option:selected

So, if you can confirm that this accomplishes the same, I would suggest we drop the QuerySelector node, in order to avoid duplicate functionality.

As for the bugfix: I think it will be added automatically to the pull request, as soon as you push again to that branch. Probably this is what happened with the "fix CDR" commit above.

zauner avatar Sep 23 '14 10:09 zauner