zarr-python icon indicating copy to clipboard operation
zarr-python copied to clipboard

Pass mode paramter to open_group enabling creation of new ZipStores

Open hmaarrfk opened this issue 5 years ago • 4 comments
trafficstars

The mode parameter was ignored in the case of ZipStores because it wasn't passed along to the normalize function.

Is there a way to add notes to the changelog?

TODO:

  • [ ] Add unit tests and/or doctests in docstrings
  • [ ] Add docstrings and API docs for any new/modified user-facing classes and functions
  • [ ] New/modified features documented in docs/tutorial.rst
  • [ ] Changes documented in docs/release.rst
  • [ ] AppVeyor and Travis CI passes
  • [ ] Test coverage is 100% (Coveralls passes)

hmaarrfk avatar Aug 31 '20 20:08 hmaarrfk

Failure seem to be dues to numpy/setuptools recent changes that break the builds. NOthing related to this code. Maybe just rebasing will be sufficient.

Is there a way to add notes to the changelog?

As far as I can tell people edit docs/release.rst directly.

Carreau avatar Sep 09 '20 21:09 Carreau

Master seems updated.

hmaarrfk avatar Sep 09 '20 22:09 hmaarrfk

Hi @hmaarrfk. Sorry that this slipped through the cracks. Do you mind taking a look at the recent changes to the mainline that are causing some conflicts?

joshmoore avatar Feb 18 '21 16:02 joshmoore

No issues. I'll see again when I get some time

hmaarrfk avatar Feb 19 '21 04:02 hmaarrfk