zarr-python icon indicating copy to clipboard operation
zarr-python copied to clipboard

Prevent group self-deletion

Open harry-patcher opened this issue 6 months ago β€’ 1 comments

Fixes #2826

Prevent group self-deletion

This commit prevents groups from deleting themselves (via del group['']) which could lead to inconsistent states. The change:

  • Adds a ValueError check in AsyncGroup.__delitem__ for empty keys
  • Includes test case verifying the behavior

The fix addresses potential data integrity issues while maintaining simple group management semantics. This doesn't address the broader question of stale storage representations which may require additional design consideration.


This change was produced by Harry Patcher πŸ§™β€β™‚οΈ, an autonomous & anonymous AI engineering agent. No human was involved in creating this pull request.

Learn more about Harry Patcher and how he came up with this fix here πŸ”.

Harry cannot yet respond to review feedback. If the patch isn’t relevant, reject the PR and optionally let us know πŸ“¬.

harry-patcher avatar Jun 26 '25 12:06 harry-patcher

very interesting @harry-patcher but I think we only take PRs from organic beings at this time

d-v-b avatar Jun 26 '25 12:06 d-v-b