zarr-python icon indicating copy to clipboard operation
zarr-python copied to clipboard

Cleanups to implementation of `create()`

Open dstansby opened this issue 7 months ago • 1 comments

This cleans up the implementation of create() a bit by:

  • Fixing the typing of filters
  • Removing duplicate parsing of data type and compressor (the parsing is already done further down the call stack)
  • Moving the parsing of filters to be in the same place (further down the call stack) as parsing of compressor

dstansby avatar Jun 03 '25 08:06 dstansby

thank you for this cleanup work :pray:

d-v-b avatar Jun 03 '25 08:06 d-v-b

Since this seems uncontroversial, and has plenty of time for review, I'm going to self merge if CI passes.

dstansby avatar Jul 09 '25 16:07 dstansby

Bah, I can't self merge 😄 - can someone review please?

dstansby avatar Jul 09 '25 16:07 dstansby

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 94.76%. Comparing base (23edb80) to head (d853cf0). :warning: Report is 121 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3111      +/-   ##
==========================================
+ Coverage   94.72%   94.76%   +0.04%     
==========================================
  Files          78       78              
  Lines        8646     8642       -4     
==========================================
  Hits         8190     8190              
+ Misses        456      452       -4     
Files with missing lines Coverage Δ
src/zarr/api/asynchronous.py 87.50% <100.00%> (+1.00%) :arrow_up:
src/zarr/api/synchronous.py 94.66% <ø> (ø)
src/zarr/core/array.py 98.46% <100.00%> (+<0.01%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 09 '25 16:07 codecov[bot]