zarr-python icon indicating copy to clipboard operation
zarr-python copied to clipboard
verified publisher icon zarr-developers

Ruff conflicts with pep8

Open normanrz opened this issue 1 year ago • 1 comments

In this PR #1839 I have a conflict where the @pep8speaks bot is in conflict with the ruff formatter. PEP8 comment: https://github.com/zarr-developers/zarr-python/pull/1839#issuecomment-2094937391 Ruff pre-commit: https://results.pre-commit.ci/run/github/48049137/1715025400.r2onHl8LSX240CJ0_K4lOw

The difference is illustrated in this commit: https://github.com/zarr-developers/zarr-python/pull/1839/commits/d8b5ca7748f0d1a0bcb049aa414aac4bdbc2d876

normanrz avatar May 06 '24 20:05 normanrz

I would be in favor of removing the pep8speaks bot in favor of strict Ruff rules (similar to what are being applied in #1702).

jhamman avatar May 07 '24 15:05 jhamman

@MSanKeys963 - I don't have privileges to turn off pep8speaks here. Can you do that for us?

jhamman avatar May 11 '24 05:05 jhamman

Hi @jhamman. I just checked, and my privileges are the same as yours and ZP core developers. @joshmoore, can you help us here?

sanketverma1704 avatar May 11 '24 13:05 sanketverma1704

Here are the installed apps:

image

I've "suspended" pep8speaks. Let's see if that does the right thing. (I've also removed travis)

At one of the first core devs meetings, let's go through permissions and set things up correctly.

joshmoore avatar May 11 '24 14:05 joshmoore

Thanks!

normanrz avatar May 14 '24 19:05 normanrz