zarr-python icon indicating copy to clipboard operation
zarr-python copied to clipboard

Apply assorted Repo-Review suggestions

Open DimitriPapadopoulos opened this issue 1 year ago • 2 comments

Mostly stricter pytest and MyPy settings.

TODO:

  • [ ] Add unit tests and/or doctests in docstrings
  • [ ] Add docstrings and API docs for any new/modified user-facing classes and functions
  • [ ] New/modified features documented in docs/tutorial.rst
  • [ ] Changes documented in docs/release.rst
  • [x] GitHub Actions have all passed
  • [x] Test coverage is 100% (Codecov passes)

DimitriPapadopoulos avatar Mar 12 '24 09:03 DimitriPapadopoulos

Hello @DimitriPapadopoulos! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-05-07 15:56:55 UTC

pep8speaks avatar Mar 12 '24 10:03 pep8speaks

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.99%. Comparing base (270aff1) to head (10f725c).

:exclamation: Current head 10f725c differs from pull request most recent head b109932. Consider uploading reports for the commit b109932 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1705   +/-   ##
=======================================
  Coverage   99.98%   99.99%           
=======================================
  Files          38       38           
  Lines       14667    14580   -87     
=======================================
- Hits        14665    14579   -86     
+ Misses          2        1    -1     
Files Coverage Δ
zarr/_storage/store.py 100.00% <100.00%> (ø)
zarr/_storage/v3.py 100.00% <100.00%> (ø)
zarr/convenience.py 100.00% <100.00%> (ø)
zarr/storage.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

codecov[bot] avatar Mar 12 '24 22:03 codecov[bot]

@DimitriPapadopoulos - thanks for moving your focus over to the v3 branch. I'm going to close this in favor of the contributions you've already made there. 🙏

jhamman avatar Jun 01 '24 16:06 jhamman