zarr-python icon indicating copy to clipboard operation
zarr-python copied to clipboard

Resolve Mypy errors in `v3` branch

Open jhamman opened this issue 2 years ago • 2 comments

The v3 branch needs some Mypy attention. As expected, our port of the zarrita code (see https://github.com/zarr-developers/zarr-python/pull/1584) has left a number of mypy errors that would be great to resolve.

This ticket can be closed when:

  • [ ] we have CI running against the v3 codebase
  • [ ] we have zero mypy errors when checked in a github action

Marking this as help-wanted!

jhamman avatar Dec 07 '23 20:12 jhamman

This is feeling like a fairly high priority to start ticking off. For now, I've disabled the mypy checks in pre-commit (#1649) but this should be a short lived state.

jhamman avatar Feb 06 '24 17:02 jhamman

I wanted to get into zarr a little and this issue had "help wanted" tag, so I picked it up here: https://github.com/zarr-developers/zarr-python/pull/1692

I made a few choices in fixing some of the issues, hope it helps more than adds noise 🙂

DahnJ avatar Mar 04 '24 18:03 DahnJ

closed by https://github.com/zarr-developers/zarr-python/pull/1692 and lots more work by @dstansby. See https://github.com/zarr-developers/zarr-python/issues/1783 for ongoing work on this topic.

jhamman avatar May 17 '24 04:05 jhamman