zarr-python icon indicating copy to clipboard operation
zarr-python copied to clipboard

Hard-code .zmetadata in FSStore._normalize_key

Open joshmoore opened this issue 2 years ago • 3 comments

The normalization code in FSStore uses a list of well-known files to prevent incorrectly re-writing keys when dimension separator is "/" rather than ".". This was initialized only with the names specified in the spec, which left out ".zmetadata" from consolidated metadata.

see: #1121

TODO:

  • [ ] Add unit tests and/or doctests in docstrings
  • [ ] Add docstrings and API docs for any new/modified user-facing classes and functions
  • [ ] New/modified features documented in docs/tutorial.rst
  • [ ] Changes documented in docs/release.rst
  • [ ] GitHub Actions have all passed
  • [ ] Test coverage is 100% (Codecov passes)

joshmoore avatar Jul 17 '23 04:07 joshmoore

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.99%. Comparing base (0b0ac88) to head (0350a24). Report is 521 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1467   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files          38       38           
  Lines       14574    14574           
=======================================
  Hits        14573    14573           
  Misses          1        1           
Files with missing lines Coverage Δ
zarr/storage.py 100.00% <100.00%> (ø)

codecov[bot] avatar Jul 17 '23 04:07 codecov[bot]

It would be good to have a failing test in the suite before this gets merged.

joshmoore avatar Jul 18 '23 00:07 joshmoore

Any thoughts about getting this into the 2.17.x line?

joshmoore avatar Feb 14 '24 21:02 joshmoore

I'm going to close this as stale. Folks should feel free to reopen if there is interest in continuing this work.

jhamman avatar Oct 11 '24 23:10 jhamman