zarr-python icon indicating copy to clipboard operation
zarr-python copied to clipboard

Bump Numpy required version to 1.17

Open DimitriPapadopoulos opened this issue 3 years ago β€’ 2 comments

We use the named parameter shape of numpy.empty_like:

  • https://github.com/zarr-developers/zarr-python/blob/4362bb4/zarr/hierarchy.py#L145
  • https://github.com/zarr-developers/zarr-python/blob/4362bb4/zarr/core.py#L2134-L2135
  • ...

It had been introduced in Numpy 1.17.0: https://numpy.org/doc/stable/reference/generated/numpy.empty_like.html

TODO:

  • [ ] Add unit tests and/or doctests in docstrings
  • [ ] Add docstrings and API docs for any new/modified user-facing classes and functions
  • [ ] New/modified features documented in docs/tutorial.rst
  • [ ] Changes documented in docs/release.rst
  • [X] GitHub Actions have all passed
  • [X] Test coverage is 100% (Codecov passes)

DimitriPapadopoulos avatar Oct 16 '22 07:10 DimitriPapadopoulos

Perhaps test against the oldest supported version instead of / in addition to the latest version: https://github.com/zarr-developers/zarr-python/blob/4362bb438f537b37ebd271506b774dfa31f5e68e/requirements_dev_numpy.txt#L1-L4

DimitriPapadopoulos avatar Oct 16 '22 08:10 DimitriPapadopoulos

Thanks Dimitri! πŸ™

Merging once CI passes πŸ˜„

jakirkham avatar Oct 18 '22 21:10 jakirkham

Codecov Report

Merging #1192 (b99505d) into main (da7ba0c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1192   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files          35       35           
  Lines       14135    14136    +1     
=======================================
+ Hits        14134    14135    +1     
  Misses          1        1           
Impacted Files Coverage Ξ”
zarr/util.py 100.00% <0.00%> (ΓΈ)

codecov[bot] avatar Oct 18 '22 23:10 codecov[bot]