zarr-python
zarr-python copied to clipboard
Bump Numpy required version to 1.17
We use the named parameter shape of numpy.empty_like:
- https://github.com/zarr-developers/zarr-python/blob/4362bb4/zarr/hierarchy.py#L145
- https://github.com/zarr-developers/zarr-python/blob/4362bb4/zarr/core.py#L2134-L2135
- ...
It had been introduced in Numpy 1.17.0: https://numpy.org/doc/stable/reference/generated/numpy.empty_like.html
TODO:
- [ ] Add unit tests and/or doctests in docstrings
- [ ] Add docstrings and API docs for any new/modified user-facing classes and functions
- [ ] New/modified features documented in docs/tutorial.rst
- [ ] Changes documented in docs/release.rst
- [X] GitHub Actions have all passed
- [X] Test coverage is 100% (Codecov passes)
Perhaps test against the oldest supported version instead of / in addition to the latest version: https://github.com/zarr-developers/zarr-python/blob/4362bb438f537b37ebd271506b774dfa31f5e68e/requirements_dev_numpy.txt#L1-L4
Thanks Dimitri! π
Merging once CI passes π
Codecov Report
Merging #1192 (b99505d) into main (da7ba0c) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## main #1192 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 35 35
Lines 14135 14136 +1
=======================================
+ Hits 14134 14135 +1
Misses 1 1
| Impacted Files | Coverage Ξ | |
|---|---|---|
| zarr/util.py | 100.00% <0.00%> (ΓΈ) |