zarr-python icon indicating copy to clipboard operation
zarr-python copied to clipboard
verified publisher icon zarr-developers

Change non-string attribute key from warning to error

Open joshmoore opened this issue 3 years ago • 5 comments

follow-up to #1037 #1066 to perform the breaking change that we were not yet ready to make:

z1.attrs.put({1: "bar", "foo": "bar"})  # Error

joshmoore avatar Sep 08 '22 06:09 joshmoore

It will be my pleasure to work on this issue.

I-am-Emmanuel avatar Oct 12 '22 18:10 I-am-Emmanuel

I recently completed this project. Waiting to be merged

I-am-Emmanuel avatar Oct 13 '22 12:10 I-am-Emmanuel

Hi @I-am-Emmanuel. Thanks for working on this. We'll review your PR #1183.

sanketverma1704 avatar Oct 13 '22 13:10 sanketverma1704

Hi @I-am-Emmanuel. After going through the issue, I realised this issue is a breaking change and needs to be handled by the maintainers for the Zarr python only. I think I added the good-first-issue label accidentally, and I sincerely apologise for that. 🙏🏻

Can you please work on another issue? I'm happy to help you find one if you can't find one.

sanketverma1704 avatar Oct 13 '22 13:10 sanketverma1704

Alright

I-am-Emmanuel avatar Oct 13 '22 13:10 I-am-Emmanuel