zarr-python icon indicating copy to clipboard operation
zarr-python copied to clipboard

Adding GitHub release publishing step (when tagging)

Open jakirkham opened this issue 3 years ago • 4 comments
trafficstars

One of the missing pieces from our automation now is that we don't make release (with notes) when a tag is made. This GitHub Action might help us fill that gap

https://github.com/marketplace/actions/github-create-tag-release

cc @joshmoore

jakirkham avatar Sep 01 '22 16:09 jakirkham

ah, true. https://github.com/zarr-developers/zarr-python/pull/1119 is something of an alternative proposal. If we go with "github-create-tag-release" then we likely shouldn't encourage people to create releases on GitHub and instead just tags.

joshmoore avatar Sep 02 '22 08:09 joshmoore

Hi, @MSanKeys963 ! I'm an Outreachy applicant, can I claim to contribute to this issue?

julianavmgiusti avatar Oct 12 '22 20:10 julianavmgiusti

Hi @julianavmgiusti. Yeah, sure! Please go ahead. Let us know if you need any help resolving this issue.

sanketverma1704 avatar Oct 12 '22 22:10 sanketverma1704

@MSanKeys963 Thank you very much! I just saw your message, my notifications was off I don't know why, but now is ON!

julianavmgiusti avatar Oct 13 '22 17:10 julianavmgiusti

@joshmoore and @MSanKeys963 I believe that to be able to move forward, I would need to create a file .github/release.yml to create the release.yml file in the .github directory. I would like to know if it is the way or am I mistaken?

julianavmgiusti avatar Oct 18 '22 13:10 julianavmgiusti

Think most of what we need is here. Basically this is discussing adding one more step to that workflow. Namely this one. Does that make sense?

jakirkham avatar Oct 18 '22 19:10 jakirkham

@julianavmgiusti, .github/workflow/release.yml file is already in the repo. I think you just need to include the syntax for 'github-tag-release'

GbotemiB avatar Oct 19 '22 10:10 GbotemiB

greeting @MSanKeys963 I will like to know if I can work on this issues as well

steph237 avatar Oct 20 '22 02:10 steph237

Hi Stephanie! 👋 Thanks for the offer to help here! 🙏

Juliana picked this up with PR ( https://github.com/zarr-developers/zarr-python/pull/1204 ) recently. Sorry that didn't show up in the history of this issue previously (have updated it).

That said, please feel free to pick up another issue. Would be great to have your help here as well 🙂

jakirkham avatar Oct 21 '22 06:10 jakirkham

thank you @jakirkham I have gone through the issues and I am finding it difficult to pick one because of the the lack of labels

steph237 avatar Oct 21 '22 06:10 steph237

@jakirkham: just a follow up as @MSanKeys963 and I review labels, what did you mean with "maintenance" here?

joshmoore avatar Nov 23 '22 15:11 joshmoore

It is not a bug in the library or a feature request for the library. It is part of regular maintenance of this project (like CI)

jakirkham avatar Nov 23 '22 17:11 jakirkham

Hey can I work on this issue? @MSanKeys963

callmetushar123 avatar Feb 05 '23 13:02 callmetushar123

Hi @callmetushar123. Yeah, sure. Please go ahead. Let us know if you need any help resolving this issue.

sanketverma1704 avatar Feb 05 '23 21:02 sanketverma1704

@MSanKeys963 can you put the assign tag on me?

callmetushar123 avatar Feb 06 '23 01:02 callmetushar123

Can someone guide me a bit, i am relatively new to open source

callmetushar123 avatar Feb 06 '23 08:02 callmetushar123

Can someone guide me a bit, i am relatively new to open source

For sure. Did you go through the conversation above? Especially this comment?

sanketverma1704 avatar Feb 06 '23 11:02 sanketverma1704

I haven't. I will do it

callmetushar123 avatar Feb 06 '23 14:02 callmetushar123