numcodecs icon indicating copy to clipboard operation
numcodecs copied to clipboard

Published 20 hours ago • verified publisher icon zarr-developers

Unvendor cpuinfo

Open DimitriPapadopoulos opened this issue 3 years ago • 8 comments

Because the cpuinfo module is required by setup.py, we need to pull it with pyproject.toml.

~~I think it is not needed in requirements_dev.txt.~~

TODO:

  • [ ] Unit tests and/or doctests in docstrings
  • [ ] tox -e py310 passes locally
  • [ ] Docstrings and API docs for any new/modified user-facing classes and functions
  • [x] Changes documented in docs/release.rst
  • [ ] tox -e docs passes locally
  • [x] GitHub Actions CI passes
  • [x] Test coverage to 100% (Coveralls passes)

DimitriPapadopoulos avatar Oct 28 '22 17:10 DimitriPapadopoulos

This pull request fixes 5 alerts when merging 67dec4dfe15b216962f0d8e17fad735b7f10a1fe into d12b54b4f9c56febee087fb7d2e7d2d5e34f40f2 - view on LGTM.com

fixed alerts:

  • 4 for Unused local variable
  • 1 for Module is imported with 'import' and 'import from'

lgtm-com[bot] avatar Oct 28 '22 17:10 lgtm-com[bot]

Thanks Dimitri! 🙏

jakirkham avatar Oct 28 '22 17:10 jakirkham

This pull request fixes 5 alerts when merging 19ea966b74da6e29bd59e3a340c1e56e4b5560f2 into d12b54b4f9c56febee087fb7d2e7d2d5e34f40f2 - view on LGTM.com

fixed alerts:

  • 4 for Unused local variable
  • 1 for Module is imported with 'import' and 'import from'

lgtm-com[bot] avatar Oct 28 '22 17:10 lgtm-com[bot]

This pull request fixes 5 alerts when merging 8dc047f12b3f0b5b2212d8ed9ec4acf38cb9a13c into d12b54b4f9c56febee087fb7d2e7d2d5e34f40f2 - view on LGTM.com

fixed alerts:

  • 4 for Unused local variable
  • 1 for Module is imported with 'import' and 'import from'

lgtm-com[bot] avatar Oct 28 '22 17:10 lgtm-com[bot]

This pull request fixes 5 alerts when merging 7059ebc9f32338c39f3b6179d08347cc75c43e14 into 0a2ec9feae252f587ce85f7bfd28d29374190336 - view on LGTM.com

fixed alerts:

  • 4 for Unused local variable
  • 1 for Module is imported with 'import' and 'import from'

lgtm-com[bot] avatar Oct 28 '22 18:10 lgtm-com[bot]

This pull request fixes 5 alerts when merging 8705ee317504810c70d110a63f01e70950da9624 into 0a2ec9feae252f587ce85f7bfd28d29374190336 - view on LGTM.com

fixed alerts:

  • 4 for Unused local variable
  • 1 for Module is imported with 'import' and 'import from'

lgtm-com[bot] avatar Oct 28 '22 19:10 lgtm-com[bot]

This pull request fixes 5 alerts when merging c649c9b835d8a4f7043742587b90eb7a80c5b804 into 0a2ec9feae252f587ce85f7bfd28d29374190336 - view on LGTM.com

fixed alerts:

  • 4 for Unused local variable
  • 1 for Module is imported with 'import' and 'import from'

lgtm-com[bot] avatar Oct 28 '22 20:10 lgtm-com[bot]

This pull request fixes 5 alerts when merging 6164e686d5a37587d2a78d5bf5710636b8e15e8d into 0a2ec9feae252f587ce85f7bfd28d29374190336 - view on LGTM.com

fixed alerts:

  • 4 for Unused local variable
  • 1 for Module is imported with 'import' and 'import from'

lgtm-com[bot] avatar Oct 29 '22 08:10 lgtm-com[bot]

This pull request fixes 5 alerts when merging 1e1d58e08133a07ac0fa500d8b51efe89bbb7c39 into 61a90da47c76af6c5c3af7d012c7ab9a94ec7f13 - view on LGTM.com

fixed alerts:

  • 4 for Unused local variable
  • 1 for Module is imported with 'import' and 'import from'

lgtm-com[bot] avatar Oct 29 '22 20:10 lgtm-com[bot]

Thanking of the upcoming release, best to bump to 0.11 with the new dependency?

joshmoore avatar Oct 31 '22 19:10 joshmoore

Agreed. Opened issue ( https://github.com/zarr-developers/numcodecs/issues/377 ) so we can sort out anything for the next release. Hoping to have a couple more build fixes done, but will see. Depends on time constraints & help from others (like with pyproject.toml)

jakirkham avatar Oct 31 '22 19:10 jakirkham