Rvcg icon indicating copy to clipboard operation
Rvcg copied to clipboard

Update vcgCreateKD.r

Open mcranium opened this issue 8 months ago • 2 comments

I added some information about the query object to the documentation. In general, I think it would be best to use the same naming scheme for the regular search and the one with barycenters (but that might break some peoples code). Now, one function is named vcgSearchKDtree and the other is named vcgClostOnKDtreeFromBarycenters. The latter naming scheme would be geometrically more descriptive.

Also, I fixed a typo: atrix -> matrix

mcranium avatar Jul 25 '25 08:07 mcranium

Hi @mcranium, thanks for the PR. You are right regarding the naming scheme. We could change the name and use the old name as an alias so the code won't break but with a deprecated warning, like here: https://github.com/zarquon42b/Rvcg/blob/c1fcfd999902e8e2244c6161cb790de5763871e5/R/Rvcg-package.R#L67

zarquon42b avatar Jul 25 '25 08:07 zarquon42b

I am not familiar with how this needs to be implemented, but if this is possible I think this would be a good idea. As a user, I would prefer vcgClostOnKDtree over vcgSearchKDtree because it is a bit more descriptive about the direction (which points are being iterated over). The mnemonic is "[find] closest [corresponding point] on KD-tree", right?

mcranium avatar Jul 25 '25 10:07 mcranium