Anatolii Smolianinov

Results 28 comments of Anatolii Smolianinov

:+1: , it is critical in some vita-only games https://www.reddit.com/r/VitaPiracy/comments/9j9z9g/mgs3_on_pstv_cre_menu_touch_controls_dpad/? > Hi! trying to play MGS3 on pstv, but having troubles with emulated touch controls. In "cure" menu, I have...

@svonduhn thanks for this PR! GET from works good for me, but I didn't manage to get POST request to work. For example, `/record/v1/customer` with body parameters. I see "invalid...

@svonduhn thanks for your reply! I get it to work, but the issue was that I've added body parameters to signature. It was a stupid mistake, but for some reason...

Hello! I've noticed this "good first issue" label and decided give it a try. I haven't covered all the cases (including tests) -- metadata fails are not handled -- but...

@zwpaper thanks for your feedback! Please check this recent commit https://github.com/Peltoche/lsd/pull/536/commits/3bca4047097b487b8b6675a5e7405ce56b1a71be if I understood your approach correct. If it is the case, I'll proceed with mod.rs and tests.

BTW, I've noticed that `Meta::recurse_into` from `mod.rs` never returns an `Error`.. I think because of this [Err branch from recurse in fetch](https://github.com/zarkone/lsd/blob/502-file-not-found-exit-status/src/core.rs#L124) never gets executed if you test it with...

@meain this is a good observation! And even more -- GNU `ls` doesn't collect/buffer anything at all -- it prints all the info right away. `lsd`, on the contrary, uses...

@meain sounds good, thanks for the feedback! How about the other points? About error propagation from mod.rs and the implementation in general?

> @zarkone Yeah, you are right. As of now we are not returning any errors. Mostly it is just print the error and continue, but we can change that to...

@zwpaper @meain updated the PR -- kindly ask you to check my yet unfinished code if it is a good direction overall. I feel that some tests and some code...