handynotes-plugins icon indicating copy to clipboard operation
handynotes-plugins copied to clipboard

More data in Undermine

Open pepedressingroom opened this issue 9 months ago • 10 comments

add ns.requirement.Quest support for checking "completed on account" add reputation quest ids of rares add paragon reputation rewards add C.H.E.T.T. List add Shipping & Handling rewards add a node "unlock skyrocketing races world quests" add D.R.I.V.E. customization's checklist

pepedressingroom avatar Mar 25 '25 17:03 pepedressingroom

Lint fails points to _ in these lines of undermine.lua:

572 requires = ns.requirement.Quest(83542, _, _, true), -- ![Quick Gills for Gold Now] (warband)

727 requires = ns.requirement.Quest(86961, _, _, true), -- ![Diversified Investments] (warband)

817 ns.requirement.Quest(87374, _, _, true) -- ![C.H.E.T.T.ing In] (warband)

837 ns.requirement.Quest(87374, _, _, true) -- ![C.H.E.T.T.ing In] (warband)

Krovikan avatar Mar 25 '25 17:03 Krovikan

图片

all about this non-localization, is from QuestV2CliTask.db2

but in CriteriaTree.db2 the same name was localized.

adavak avatar Mar 27 '25 13:03 adavak

@pepedressingroom The quantities of someone (currency or items) have this format: 40x {currency:XXXXXX}

I added the x to your line 657: L['chett_extra'] = 'Exchange 40x {item:236668} for an extra {item:236682}.\n'

I have other petition. I need help to understand this lines:

652 L['chett_exchange_1'] = 'Chose to exchange {item:235053} for?\n\n #1. ' .. ns.color.LightBlue('250') .. ' {currency:3008}\n (Bring back to {npc:238029}).\n\n #2. ' -- REVIEW

653 L['chett_exchange_2a'] = ns.color.LightBlue('500') .. ' {currency:%d} Reputation\n (Buy {item:%d} from {faction:%d} Quartermaster)\n' --REVIEW

654 L['chett_exchange_2b'] = ns.color.LightBlue('500') .. ' Aligned Cartel Reputation\n ( {note:Have to side with a cartel first this week!})\n' -- REVIEW

I don't know how to translate with all this code inside. Remember the x for valors in theses lines (250 and 500).

Maybe I can understand good these 3 lines if you can show me how is seen in the game (screenshots).

Regards

Krovikan avatar Mar 27 '25 15:03 Krovikan

@Krovikan If you have sided with a cartel this week, option #2 will look like this. L['chett_exchange_1'] .. L['chett_exchange_2a']

Chose to exchange Completed C.H.E.T.T. List for?

#1. 250 Valorstones (Bring back to {npc:238029}).

#2. 500 {currency:%d} Reputation (Buy {item:%d} from {faction:%d} Quartermaster)

If you haven't side with a cartel this week, option #2 will look like this. L['chett_exchange_1'] .. L['chett_exchange_2b']

Chose to exchange Completed C.H.E.T.T. List for?

#1. 250 Valorstones (Bring back to {npc:238029}).

#2. 500 Aligned Cartel Reputation ( {note:Have to side with a cartel first this week!})

I am sorry I made it too complex to understand.

pepedressingroom avatar Mar 27 '25 16:03 pepedressingroom

Thanks for explanations.

500 {currency:%d} Reputation 250 Valorstones

Only one last thing. The quoted text needs to be: 500x {currency:%d} Reputation 250x Valorstones

~~I don't know if you need to do in code or in locales. But better do it yourself.~~

I saw the light. The ' ' is string, so I added the x to enUS.lua and esES.lua.

Regards

Krovikan avatar Mar 27 '25 17:03 Krovikan

Rares = { -- (Daily)
-- + 20 {faction:2653}
84917, -- Scrapbeak
84918, -- Ratspit
84919, -- Tally Doublespeak
84920, -- V.V. Goosworth
84921, -- Thwack
84922, -- S.A.L.
84926, -- Nitro
84927, -- Candy Stickemup
84928, -- Grimewick
85004, -- Swigs Farsight
87007, -- Gallagio Garbage
}
RareElites = { -- (Weekly)
-- + 50 {faction:2653}
84877, -- Ephemeral Agent Lathyd
84884, -- The Junk-Wall
84895, -- Slugger the Smart
84907, -- Chief Foreman Gutso
84911, -- Flyboy Snooty
}
SummonedRareElites = { -- (Weekly)
-- + 100 {faction:2653}
-- + 150 {faction:alignedCartel}
{90491, 85778, 86431}, -- Scrapchewer
{90488, 86298, 86414}, -- M.A.G.N.O.
{90489, 86307, 86390}, -- Giovante
{90490, 85777, 86428}, -- Voltstrike the Charged
{90492, 85010, 85013}, -- Darkfuse Precipitant
}
-- SummonedRareElites[i][1] (9xxxx) have enUS strings returned by API
-- SummonedRareElites[i][2] (8xxxx) are hidden
-- SummonedRareElites[i][3] (8xxxx) have localised quest name , type of which is "Bonus Ojective with Completion Toast". These quests are not related with the loot tables.

To merge and resolve the rares quest conflicts, I have checked my QuestsChanged saved variables.

I looted "Darkfuse Precipitant" in Week 2 (since UM patch) with only quest:90492 flagged, and I remembered I did not receive any reputation. But in Week 3, I triggered both quest:90492 and quest:85010, probably because I unlocked "Darkfuse Precipitant" in that week. Darkfuse Precipitant rewards reputation now. Maybe quest:85010 was unlocked by the Darkfuse quest line, or Blizzard hotfixed it.

So that I use SummonedRareElites[i][2] (8xxxx) instead of SummonedRareElites[i][1] (9xxxx) for reputation quest ids and use SummonedRareElites[i][1] (9xxxx) for normal loot tables.

FYI: Lazey's comment on 2025/02/13

Regards

pepedressingroom avatar Apr 03 '25 12:04 pepedressingroom

i tested 8xxxx quest id worked perfect. do not need switch 9xxxx.

adavak avatar Apr 04 '25 05:04 adavak

i tested 8xxxx quest id worked perfect. do not need switch 9xxxx.

Yes, they are twins quests and interchangeable most of time.

pepedressingroom avatar Apr 04 '25 10:04 pepedressingroom

i tested 8xxxx quest id worked perfect. do not need switch 9xxxx.

Yes, they are twins quests and interchangeable most of time.

Be careful with them tho, tracking the wrong quest could cause them to display as complete or not complete(even when killed) on different characters, when two quests are triggered, ideally you should then validate which is then triggered on a different char and that would be the rare kill tracking quest the other should be the rep

tfmonk avatar Apr 04 '25 12:04 tfmonk

i tested 8xxxx quest id worked perfect. do not need switch 9xxxx.

Yes, they are twins quests and interchangeable most of time.

Be careful with them tho, tracking the wrong quest could cause them to display as complete or not complete(even when killed) on different characters, when two quests are triggered, ideally you should then validate which is then triggered on a different char and that would be the rare kill tracking quest the other should be the rep

The existing questid has been verified. I used 3 characters and killed them every day without missing any.

adavak avatar Apr 04 '25 12:04 adavak

@adavak @tfmonk Blizzard has removed SummonedRareElites[i][2] (8xxxx) in patch 11.1.5, and changes reputation quests to SummonedRareElites[i][1] (9xxxx)

SummonedRareElites = { -- (Weekly)
-- + 100 {faction:2653}
-- + 300 {faction:alignedCartel} 
{90491, nil}, -- Scrapchewer
{90488, nil}, -- M.A.G.N.O.
{90489, nil}, -- Giovante
{90490, nil}, -- Voltstrike the Charged
{90492, nil}, -- Darkfuse Precipitant
}

pepedressingroom avatar Apr 24 '25 06:04 pepedressingroom

@adavak @tfmonk Blizzard has removed SummonedRareElites[i][2] (8xxxx) in patch 11.1.5, and changes reputation quests to SummonedRareElites[i][1] (9xxxx)

SummonedRareElites = { -- (Weekly)
-- + 100 {faction:2653}
-- + 300 {faction:alignedCartel} 
{90491, nil}, -- Scrapchewer
{90488, nil}, -- M.A.G.N.O.
{90489, nil}, -- Giovante
{90490, nil}, -- Voltstrike the Charged
{90492, nil}, -- Darkfuse Precipitant
}

thanks, i got that, after map icon clean and login alts the purple icon show up. i know the questid changed.

adavak avatar Apr 24 '25 08:04 adavak

@adavak @tfmonk Blizzard has removed SummonedRareElites[i][2] (8xxxx) in patch 11.1.5, and changes reputation quests to SummonedRareElites[i][1] (9xxxx)

SummonedRareElites = { -- (Weekly)
-- + 100 {faction:2653}
-- + 300 {faction:alignedCartel} 
{90491, nil}, -- Scrapchewer
{90488, nil}, -- M.A.G.N.O.
{90489, nil}, -- Giovante
{90490, nil}, -- Voltstrike the Charged
{90492, nil}, -- Darkfuse Precipitant
}

thanks, i got that, after map icon clean and login alts the purple icon show up. i know the questid changed.

Due to this change, I guess you can receive reputation as a raid member now. But there may be a bad situation. If you kill these 5 rares before aligning with a Cartel, you will miss out on your aligned Cartel's reputation for the week. If it was the case, it's better to add a warning in the notes. But I cannot test it this week on live realm.

regards

pepedressingroom avatar Apr 24 '25 11:04 pepedressingroom