handynotes-plugins icon indicating copy to clipboard operation
handynotes-plugins copied to clipboard

Cosmetic update

Open Dathwada opened this issue 10 months ago • 2 comments

Dathwada avatar Apr 14 '24 12:04 Dathwada

Would this be a good branch to fix rare vignette tooltips? Currently we are showing rewards on the rare vignette tooltip even if the Rare group is unchecked in the World Map Button dropdown. I think that feature should honor the checkbox instead. Thoughts?

wyldclaw avatar Apr 15 '24 19:04 wyldclaw

Would this be a good branch to fix rare vignette tooltips?

I don't think it matters in which branch this is fixed. When this branch is merged in a few days.

Currently we are showing rewards on the rare vignette tooltip even if the Rare group is unchecked in the World Map Button dropdown. I think that feature should honor the checkbox instead.

Yes, I think it's a good idea to implement this.


Before we merge this, I want to double check the transmog because I noticed that the wowhead xml sometimes doesn't match the real subclass/slot.

e.g. This two items are boath Cosmetic and Cloaks but the xml subclass is diffenent: Item:181810 subclass: Cosmetic Item:188686 subclass: Cloaks

Dathwada avatar Apr 15 '24 20:04 Dathwada

This looks fine to me. Let me know if you still want to merge this @Dathwada.

zarillion avatar Jun 06 '24 21:06 zarillion

Yes, I would still want to merge this.

Dathwada avatar Jun 07 '24 03:06 Dathwada