handynotes-plugins icon indicating copy to clipboard operation
handynotes-plugins copied to clipboard

Some fixes and additions

Open pepedressingroom opened this issue 1 year ago • 7 comments

pepedressingroom avatar Nov 13 '23 04:11 pepedressingroom

just paste the link to the commit like so : https://github.com/zarillion/handynotes-plugins/pull/389/commits/f1b76a3e1fb83d350e1c5a846f16b0f5e79488fb https://github.com/zarillion/handynotes-plugins/pull/389/commits/f1b76a3e1fb83d350e1c5a846f16b0f5e79488fb

Ioney avatar Nov 13 '23 23:11 Ioney

just paste the link to the commit like so : https://github.com/zarillion/handynotes-plugins/pull/389/commits/f1b76a3e1fb83d350e1c5a846f16b0f5e79488fb f1b76a3

Thank you @Ioney

pepedressingroom avatar Nov 14 '23 03:11 pepedressingroom

@pepedressingroom You have a mistake in all locales and in Azure_span.lua

L["altar_of_decay_label"] must be L['altar_of_decay_label'].

Regards

Krovikan avatar Nov 17 '23 10:11 Krovikan

L["altar_of_decay_label"] must be L['altar_of_decay_label']

Thank you @Krovikan

pepedressingroom avatar Nov 17 '23 10:11 pepedressingroom

@pepedressingroom L['khadin_prof_note'] = 'Gana %d more {currency:%d}s to max out {spell:%d} profession tree.'

You can show me a sentence did it with %d replaced? Can be of any profession, only for translate accurate.

Regards

Krovikan avatar Dec 01 '23 11:12 Krovikan

@pepedressingroom L['khadin_prof_note'] = 'Gana %d more {currency:%d}s to max out {spell:%d} profession tree.'

You can show me a sentence did it with %d replaced? Can be of any profession, only for translate accurate.

Regards

屏幕截图 2023-12-02 001910

@Krovikan I list how many currencies to max out tree nodes of the 2 professions for a player to decide either one to exchange Dragon Shards. My English is not good, and do you think the sentences make sense?

Regards.

pepedressingroom avatar Dec 01 '23 16:12 pepedressingroom

Looks like some globals need to be added to .luacheckrc still for the build to pass. I'm going to wait on merging these for now.

zarillion avatar Jan 17 '24 02:01 zarillion

@pepedressingroom Is there anything else you want to add to this PR?

should be possible, i think we just need the quest id and add another hook function

Ioney avatar Jul 23 '24 19:07 Ioney

@loney

I've been AFK for round half a year, since the returning news of the china server. Due to my lacking of experience, this PR looks like a great mess. Maybe I should not add too many things in one PR, and please help look after this PR.

I still have some thought and data to add in Dragonflight, but it will take me some time to sort.

pepedressingroom avatar Jul 23 '24 21:07 pepedressingroom

@pepedressingroom you did a lot of commits since your last comment, are you still working on something or can i merge this PR?

Ioney avatar Aug 02 '24 12:08 Ioney

@Ioney This PR seems ready to be merged now. Thank you for your guys help.

pepedressingroom avatar Aug 02 '24 21:08 pepedressingroom