Vitaly
Vitaly
I mean I don't see any problems with the function in this pr and having that json file in mc-data pr. There is no alternatives for now (features don't have...
> You example itself is already showing that this renaming is not without semantic changes. I have already said above that only the flattening changes the semantic meaning of many...
> `I just need to get the block` which block? How do you know you want this one? What are some examples of use cases? Just look at diamond-square for...
> trying to map everything to one version definitely is not the approach we are taking here; and would make the code overall much less robust why less robust? I...
> I think we need to properly support all blocks instead of doing renames that are actually not the same blocks Of course we don't want to have renames maps...
https://github.com/zardoy/prismarine-web-client/commit/6090493bf08310ece0cc861d773a5afc24f008e1 the breakage wasn't intentional. also IMO isAir block property should be used here instead (example: https://github.com/PrismarineJS/minecraft-data/pull/829/files#diff-0d255e355947920697ca68432e2877c7814032af84c682c8281e725b232226fa)
This is what i meant by the sentence above. @[rom1504](https://github.com/rom1504) BTW your idea of grouped block fits well here (air blocks) but still has nothing in common with https://github.com/PrismarineJS/node-minecraft-data/pull/335
Welp, I made [read-browser-tabs](https://npmjs.com/package/read-browser-tabs), which fixes the problem and also has typings 🚀
Извиняюсь за предоставление информаци в настолько неструктурированном виде, надеюсь, что всё более менее понятно 😃
> Definitely too many `any`s to my liking, but for a lot of them I am too unfamilliar with the data structure to write proper typings. What do you think...