zar3bski

Results 21 comments of zar3bski

@spacewander @shuaijinchao Plz give me a approval :)

I removed the `post-form` composite arg, added Unit tests, squashed the branch and I think that we are good to go. While syncing my fork, Github integrated origin/main in a...

I'm puzzled by how tests behave differently locally and on the CI ## Locally Whether I run `cargo test` from **main** or from **289389df72a5567eccaa5b11a9940edfca68daaf**, I end up with this unrelated...

@epi052 ready for your review. Two comments on it. 1. I initiated an `Enum` in *src/config/utils.rs* instead of handling the literal headers values in `src/config/container.rs`. The idea behind it was...

@epi052 You're probably busy so no rush but I would like arbitrate point 1. and finish this PR in the next following weeks. Tell me what you prefer.

Don't worry about the delay, @epi052 , no problem at all (I'm not the quick type). I finally understood why I **did not get any logs** from `feroxbuster::config`, no matter...

Here we go. Do you prefer if I **squash some of the commits** or do you squash all of them on merge?

Hi @epi052 ! Are de good to go?

Experiencing a similar duplication issue. ```log ts=2024-06-28T07:06:10.839582748Z caller=writer.go:157 level=debug name=receive component=receive component=receive-writer tenant=default-tenant msg="Duplicate sample for timestamp" lset="{__name__=\"extra_kube_persistentvolumeclaim_labels\", container=\"kube-state-metrics\", endpoint=\"http\", exported_namespace=\"enviro-master-civil-finances\", instance=\"10.131.2.153:8080\", job=\"kube-state-metrics\", label_enviro_group_com_storage_key=\"m14-82-w19-nb\", label_enviro_group_com_storage_parent_id=\"0ba87ea0-868f-4284-8da9-c154ea4d5ade\", label_enviro_group_com_storage_type=\"master\", namespace=\"monitoring\", persistentvolumeclaim=\"9399b50d-20d9-45ad-931a-ed4c86ad1d44\", pod=\"extra-kube-state-metrics-6b8f9b7868-lxr72\", prometheus=\"openshift-user-workload-monitoring/user-workload\",...