lab icon indicating copy to clipboard operation
lab copied to clipboard

lab issue list is broken

Open fmuellner opened this issue 8 months ago • 5 comments

This seems to be fallout from the client-go port:

$ lab issue list
2025/04/03 14:44:29 ERROR: issue_list.go:124: issueAssigneeID (%!s(*gitlab.AssigneeIDValue=<nil>)) cannot be converted to int
$ lab issue list --assignee any
2025/04/03 14:44:49 ERROR: issue_list.go:124: issueAssigneeID (&{Any}) cannot be converted to int
$ lab issue list --assignee none
2025/04/03 14:44:54 ERROR: issue_list.go:124: issueAssigneeID (&{None}) cannot be converted to int
$ lab issue list --assignee fmuellner
2025/04/03 14:44:59 ERROR: issue_list.go:124: issueAssigneeID (&{%!s(int=31)}) cannot be converted to int

I'm afraid I wasn't able to figure out how to get from the Assignee object to the numerical ID myself, so I'm opening an issue rather than a merge request.

fmuellner avatar Apr 03 '25 12:04 fmuellner

@fmuellner thanks for finding this. I think I know what's wrong -- client-go commit 1cae3bc6f855 ("Update definitions in ListGroupIssuesOptions") changed some values from *AssigneeIDValue to *int, and a few other things. I don't think the change is correct AFAICT. If I modify a version of client-go and back out the *AssigneeIDValue to *int change, the 'lab issue list' command continues to work. I'm going to see if there was a reason the change was made.

prarit avatar Apr 03 '25 14:04 prarit

https://gitlab.com/gitlab-org/api/client-go/-/merge_requests/2234 <- let's see where this goes.

prarit avatar Apr 03 '25 18:04 prarit

@fmuellner are you only using 'lab issue list'? If so, I can just disable the Assignee lookup for now until the MR I posted upstream gets resolved.

prarit avatar Apr 03 '25 19:04 prarit

https://gitlab.com/gitlab-org/api/client-go/-/merge_requests/2234 <- well that was quick LOL.

I don't know how often they do releases though. So perhaps my previous comment is still applicable for the time being until client-go does a new release?

prarit avatar Apr 03 '25 19:04 prarit

are you only using 'lab issue list'?

Yeah, mostly as lab issue search .... But no worries, I already disabled the code in question locally :-)

fmuellner avatar Apr 03 '25 21:04 fmuellner