lab icon indicating copy to clipboard operation
lab copied to clipboard

Close issue on merge

Open prarit opened this issue 2 years ago • 3 comments

cmd/mr_create.go: Add --close-issue option

Add an option that allows a user to specify issues that can be closed when
the merge request is merged.  The --close-issue option can be used
multiple times to indicate multiple issues.

Signed-off-by: Prarit Bhargava <[email protected]>

close #844

prarit avatar Jul 14 '23 15:07 prarit

Codecov Report

Patch coverage: 56.52% and project coverage change: +0.31 :tada:

Comparison is base (cce34e2) 55.25% compared to head (971b5b7) 55.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
+ Coverage   55.25%   55.57%   +0.31%     
==========================================
  Files          82       82              
  Lines        5961     5988      +27     
==========================================
+ Hits         3294     3328      +34     
+ Misses       2380     2371       -9     
- Partials      287      289       +2     
Impacted Files Coverage Δ
cmd/mr_show.go 65.80% <0.00%> (-1.52%) :arrow_down:
cmd/mr_create.go 70.04% <59.09%> (-2.00%) :arrow_down:

... and 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 14 '23 16:07 codecov[bot]

@prarit, the code rearrangement seems odd. Only func init() is left as the final function, the command creation has been the first bit after lib imports and global var declaration, doesn't it?

bmeneg avatar Feb 26 '24 14:02 bmeneg

@bmeneg I agree, on newly created function we use Run: func(... , so it might be nice to also add it here, since you moving it

zampierilucas avatar Feb 26 '24 14:02 zampierilucas