Active scan rules take too much time to skip/stop/pause

[thc202]

Split from #1618:

What is the expected output? What do you see instead? Only the MSSQL and Advanced SQL checks should be ran, all of the DB types were running. Also when trying to skip from the scan progress screen, the checks continue.

(Emphasis mine on the problem raised by this issue.)

The problem is that the rules are not checking (in some cases more often) if the scan has been stopped (which includes the rule being skipped).

The issue does not require core changes (the rules just need to call AbstractPlugin.isStop() to check if the scan was stopped or the rule skipped).

Related issues: #936, #5855.

[kingthorin]

Are there still rules for which this is an issue?

[thc202]

That would require a review (I noticed this the other day, but it might not be possible to improve more).

[thc202]

Same goes for pausing, which even less rules check for it.

[kingthorin]

If we can agree on a pause behaviour we want I'm happy to implement it throughout the ascanrules add-ons.

Shall we just check for pause right before all the places we check stop? Wait 2 or 3 sec (looping) and resume as appropriate?

[psiinon]

Sounds good to me. Be worth having a common static for the loop time or similar..

[kingthorin]

Discussed in IRC. The current vision is for a common method in AbstractPlugin like handlePause which scan rules can call basically after everywhere they already call isStop.

It should be based on a Condition/Lock in Scanner which would propagate through HostProcess to the rules (instead of using a sleep/wait).