zaproxy-website icon indicating copy to clipboard operation
zaproxy-website copied to clipboard

Published 20 hours ago • verified publisher icon zaproxy

Cookie Consent

Open dscrobonia opened this issue 5 years ago • 3 comments

Note: This PR is still a WIP. Right now the buttons are not functional.

- Summary This PR adds a banner for cookie consent. Right now the site uses google analytics, this will allow users to opt out/in to being tracked with GA.

The banner was generated by this free tool from Osana.

If folks like the way it looks I can update the copy and work on connecting the buttons to functionality.

One nitpick from me is that I didn't like how after accepting/rejecting the cookie policy there is a floating tab at the bottom to re-open the cookie consent banner. I wish it would just go away. It is pretty small though so it's not too big a deal.

- Test plan I tried running npm run test but there are no tests that are run! :shrug:

- Description for the changelog

Adds cookie consent banner for managing Google Analytics.

image

dscrobonia avatar May 29 '20 18:05 dscrobonia

Oh nice! Will check it out asap :)

psiinon avatar Jun 01 '20 09:06 psiinon

The colour/format seems fine (good even :wink:). That's bottom of window not bottom of page right?

kingthorin avatar Jun 11 '20 14:06 kingthorin

@kingthorin yeah I pulled the actual colors from the site on that one haha. Yeah bottom of the window.

@psiinon any thoughts?

dscrobonia avatar Jun 12 '20 18:06 dscrobonia