zap-hud icon indicating copy to clipboard operation
zap-hud copied to clipboard

[WIP] Lint javascript for license header and add licence to js files

Open jveldhuijzen opened this issue 5 years ago • 9 comments

Adds license header files to javascript and lints the javascript files. Fixes #1

jveldhuijzen avatar Nov 24 '20 15:11 jveldhuijzen

Changed to WIP per above comments.

thc202 avatar Dec 07 '20 10:12 thc202

@jveldhuijzen do you still plan to work on this?

thc202 avatar Mar 09 '21 11:03 thc202

Well.. it's been busy. Where I left this off was that the lib used to to the linting (and fixing the header) wasn't able to do a replacement of the $year variable. I was busy with extending that lib (eslint-plugin-license-header) and wanted to setup a PR for them but all the unit tests for that project kept failing on my W10 machine, and I was planning on trying this out in a linux vm to see what would happen there.

So yeah, I'll try that project out in a linux vm to see where it leads me with the unit testing. I'll report back soon.

jveldhuijzen avatar Mar 09 '21 11:03 jveldhuijzen

Thank you.

thc202 avatar Mar 09 '21 11:03 thc202

As you may've wondered, I'm not getting around fixing this the right way. So I'll leave this PR for someone else to continue upon or do you guys want to close this? Running the test for that other project does work on a linux machine, not a Windows machine.

jveldhuijzen avatar Apr 26 '21 10:04 jveldhuijzen

Its funny, I've been looking for something like this for JS (after building it in rust over at https://github.com/tauri-apps/tauri ) - I have a couple cycles free this week and can pick this one up if you like @thc202

nothingismagick avatar Apr 26 '21 11:04 nothingismagick

That sounds good to me, I guess you would have to create a new PR (as you'll not be able to change this?). We can leave it open in the meantime though.

thc202 avatar Apr 27 '21 10:04 thc202

Would you prefer a proper SPDX approach? If so, who is the exact copyright holder?

nothingismagick avatar Apr 27 '21 10:04 nothingismagick

I don't think it needs to be but if it addresses the issue. We go with "The ZAP Development Team".

thc202 avatar Apr 27 '21 10:04 thc202