zap-hud
zap-hud copied to clipboard
Fix Failing JS Unit Tests & File Import Error
The code had two failing JS unit tests which has been fixed
also fixes #1103
CI should be changed to run the tests, not only to ensure that this is fixed but to not regress again.
For follow ups better use a different branch name, vue3 is misleading.
CI issue is different; this PR resolves the issue that was stopping the execution of tests locally (atleast)
So you cant run the test locally? what error messages do you get? I can run them, although the Firefox one always fails for me.
I am using npm run test to invoke ava and it is giving following error to me
This PR fixes it; afterwards the output is something like this:
Can you try ./gradlew check zapRunTests
Yeah its working fine. Isn't it utilizing Java tests? Why can't we run ava directly?
This PR fixes it; afterwards the output is something like this:
That error shows utils is not defined so the fix is not complete.
The fix is just for the import statement; not for the whole unit tests file.
Second, I can see the gradle job is running java tests, and not ava ones. Should I focus on Java unit tests or on JS ones?
For me the java tests are the most important, but the js ones would be good to fix too..
This PR fixes it; afterwards the output is something like this:
That error shows
utilsis not defined so the fix is not complete.
It is complete now
Task :npmLintAllHud FAILED - should be an easy one to fix 😁
Is it possible to execute only the failing unit test and not zapRunTests each time?