zap-hud icon indicating copy to clipboard operation
zap-hud copied to clipboard

Published 20 hours ago • verified publisher icon zaproxy

Fix some lint warnings

Open VitikaSoni opened this issue 2 years ago • 5 comments

Fixes part of #608, covered the lint warnings for the following rules:

  • no-unused-vars
  • prefer-destructuring
  • unicorn/no-for-loop
  • unicorn/prefer-includes
  • unicorn/prefer-string-slice
  • unicorn/prefer-query-selector
  • no-negated-condition

Signed-off-by: Vitika9 [email protected]

VitikaSoni avatar Jan 30 '23 13:01 VitikaSoni

@psiinon

  • For no-negated-condition do we need to change !someBool to someBool == false?
  • Do we really need to use unicorn/filename-case and change almost all the file names (just confirming before I make changes)?
  • Please let me know if I should squash all the commits into one.

Thanks!

VitikaSoni avatar Jan 30 '23 13:01 VitikaSoni

All seems sane to me.

kingthorin avatar Jan 30 '23 13:01 kingthorin

Please help me with my questions.

VitikaSoni avatar Feb 06 '23 17:02 VitikaSoni

Sorry, missed this question :(

  • Re no-negated-condition no, I dont think so - see https://eslint.org/docs/latest/rules/no-negated-condition
  • I'm fine not addressing unicorn/filename-case at this stage, its one of the less important ones imo
  • Please squash the commits into one

Re the test failure - thats unfortunately expected so we can ignore that.

psiinon avatar May 11 '23 10:05 psiinon

Have you tried testing the HUD manually with these changes? It loads for me but then none of the controls work :/ Click on the HUD buttons on ther left and right - no dialogs are shown.

psiinon avatar May 23 '23 11:05 psiinon