zap-extensions icon indicating copy to clipboard operation
zap-extensions copied to clipboard

Add TEST_TIMING alert tag

Open kingthorin opened this issue 11 months ago • 11 comments

Overview

Update: CHANGELOGs, scan rules, unittests.

Related Issues

N/A

Checklist

  • [na] Update help
  • [x] Update changelog
  • [x] Run ./gradlew spotlessApply for code formatting
  • [x] Write tests
  • [x] Check code coverage
  • [x] Sign-off commits
  • [x] Squash commits
  • [x] Use a descriptive title

kingthorin avatar Dec 17 '24 11:12 kingthorin

Logo Checkmarx One – Scan Summary & Details60bbce4c-3fcd-4a9b-995d-03b2cdca1161

Great job, no security vulnerabilities found in this Pull Request

psiinon avatar Dec 17 '24 12:12 psiinon

Updated to be correct per rule, and correct per alert.

kingthorin avatar Dec 17 '24 18:12 kingthorin

Bump

kingthorin avatar Dec 26 '24 01:12 kingthorin

Bump

kingthorin avatar Dec 30 '24 01:12 kingthorin

Deconflicted

kingthorin avatar Jan 14 '25 14:01 kingthorin

Rebased current. Clarified response to previous comment.

kingthorin avatar Mar 04 '25 15:03 kingthorin

I didn't check yet if all rules/tests are being appropriately tagged, I will wait for the rebase to double check that (some timing tests were extracted at some point into its own rules).

thc202 avatar Apr 25 '25 10:04 thc202

Hmm apparently I'm conflicting again. I'll get on that.

kingthorin avatar Apr 27 '25 00:04 kingthorin

Oops forgot to update tag counts in tests after rebasing.

Will do that tomorrow.

kingthorin avatar Apr 27 '25 02:04 kingthorin

I didn't check yet if all rules/tests are being appropriately tagged, I will wait for the rebase to double check that (some timing tests were extracted at some point into its own rules).

MongoDB is the only one split out currently as far as I can see. zaproxy/zap-extensions#4316 is still in flight.

kingthorin avatar Apr 28 '25 11:04 kingthorin

Deconflicted again, and rebased current.

kingthorin avatar May 28 '25 13:05 kingthorin

Thank you!

thc202 avatar Jun 27 '25 19:06 thc202