zap-extensions icon indicating copy to clipboard operation
zap-extensions copied to clipboard

Automation: Add active scan policy job

Open psiinon opened this issue 1 year ago • 2 comments

Overview

Adds a new activeScan-policy job.

Related Issues

Checklist

  • [x] Update help
  • [x] Update changelog
  • [x] Run ./gradlew spotlessApply for code formatting
  • [x] Write tests
  • [x] Check code coverage
  • [x] Sign-off commits
  • [x] Squash commits
  • [x] Use a descriptive title

For more details, please refer to the developer rules and guidelines.

psiinon avatar Oct 22 '24 14:10 psiinon

Ah, looks like retest has a dependency on one of the ascan methods ..

psiinon avatar Oct 22 '24 14:10 psiinon

It might look like a lot of code but its mostly existing code that has been moved around. The activeScan job already supported defining an "inline" policy. This PR moves the code into common classes so that it can be used in multiple jobs. And re your question about invalid / unavailable rules: Screenshot 2024-10-23 at 03 10 00

psiinon avatar Oct 23 '24 02:10 psiinon

Hopefully fixed everything apart from the extra line as per other comment.

psiinon avatar Oct 25 '24 10:10 psiinon

Thank you!

thc202 avatar Oct 25 '24 11:10 thc202

Updated to use lombok - best double check I've done that right 😁

psiinon avatar Oct 25 '24 11:10 psiinon