zap-extensions icon indicating copy to clipboard operation
zap-extensions copied to clipboard

tech detection: SAST Fixes (SonarLint)

Open kingthorin opened this issue 1 year ago • 1 comments

Overview

  • AppPattern > Remove unnecessary right side type declaration.
  • CHANGELOG > Add maint note.
  • ExtensionWappalyzer > Remove unused/unnecessary variables.
  • PopupMenuEvidence > Use .equals() for String comparison.
  • TechOptionsPanel > Use imports vs. fully qualified objects.
  • TechPanel > Adjust to more appropriate use of constants, use imports vs. fully qualified objects. Remove use of statically assigned/sized fonts.
  • TechPassiveScanner > Remove unnecessary right side type declaration.
  • TechJsonParser > Remove unnecessary ThreadGroup declaration and assignment.

Related Issues

N/A

Checklist

  • [na] Update help
  • [x] Update changelog
  • [x] Run ./gradlew spotlessApply for code formatting
  • [na] Write tests
  • [na] Check code coverage
  • [x] Sign-off commits
  • [x] Squash commits
  • [x] Use a descriptive title

kingthorin avatar Oct 18 '24 19:10 kingthorin

Seems fine without the static font settings

kingthorin avatar Oct 23 '24 01:10 kingthorin

Thank you!

thc202 avatar Oct 25 '24 07:10 thc202