zap-extensions icon indicating copy to clipboard operation
zap-extensions copied to clipboard

#8721 having some trouble

Open jessemchung opened this issue 1 year ago • 2 comments

Overview

Briefly describe the purpose, goals, and changes or improvements made in this pull request.

Related Issues

Specify any related issues or pull requests by linking to them.

Checklist

  • [ ] Update help
  • [ ] Update changelog
  • [ ] Run ./gradlew spotlessApply for code formatting
  • [ ] Write tests
  • [ ] Check code coverage
  • [ ] Sign-off commits
  • [ ] Squash commits
  • [ ] Use a descriptive title

For more details, please refer to the developer rules and guidelines.

jessemchung avatar Sep 26 '24 21:09 jessemchung

@thc202 Hey, sorry to bother you, but we got pretty stuck trying to figure out the best way to fix this. We are stuck trying to get resumeScan to work in attackThread. It seems like it should just match 1 to 1 in the spider thing but it doesn't seem to be working that way. Sorry this whole file is a mess at the moment, we just have been trying to add comments in places to try to fix things but the main issue right now is in AttackThread.java

If you have any guidance on the matter, it would be really helpful. I think we are missing something to link the resumeScan function to the corrresponding component in the spider dependency.

jessemchung avatar Sep 26 '24 21:09 jessemchung

https://github.com/zaproxy/zap-extensions/pull/5769#issuecomment-2377965160 I think the/a problem is https://github.com/zaproxy/zap-extensions/pull/5769#discussion_r1778827473 since that would make the (quick start) scan continue when paused.

thc202 avatar Sep 27 '24 15:09 thc202