zap-extensions
zap-extensions copied to clipboard
zaproxy
webuipoc: add react based UI
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Please create a pull request from a personal repo, otherwise we aren't able to push.
Please create a pull request from a personal repo, otherwise we aren't able to push.
Earlier I have got PRs merged from Tecvity's fork; is this a recent change?
Please create a pull request from a personal repo, otherwise we aren't able to push.
I have made a new fork on personal repository, now should I make another PR from new fork after closing this PR?
Since this is near ready I'd keep as is and for following PRs use the new fork.
Does it still need to disable the CSP, if so, are the errors as before? Ideally I'd like to see at least one working ZAP API call, even if it is just to get the top level domains from the sites tree.
Does it still need to disable the CSP, if so, are the errors as before?
The web app is working fine, the number of errors have reduced after the recent changes (I dont know how) and I can only see two CSP errors in console with UI being loaded properly.
P.S. logo is also not loading, could that be related to CSP blockages?
Update: I removed the local build from ZAP home dir and re-copied addon to ZAP which resolved the logo issue.
We've prepared a React app. It calls the API endpoint JSON/core/view/childNodes and prints data using an onClick function (just for POC)
Its ready to be merged.
CSP is not disabled anymore. As for hard-coded URLs so we can use a separate config file that defines the URLs (in-fact there are more code improvements that can be done but thats in my plan in upcoming PRs since this is not the final one)
The concern is, how can do development in the local environment with cross-origin i.e. from localhost:8000 (React's default server) if you just want to specify the endpoint and not host and port?
I dont mind how development is done, as long as when the code is checked in it uses the correct relative paths.
I dont mind how development is done, as long as when the code is checked in it uses the correct relative paths.
https://github.com/zaproxy/zap-extensions/pull/5443/commits/f276aa0ee47757095cb3ef10471dd7aae0ca2160 should handle this
Why are the React icons being added? They dont appear to be being used, and we wont need them in the future. Not a big problem, just seem unnecessary..