zap-extensions icon indicating copy to clipboard operation
zap-extensions copied to clipboard

[WIP] authhelper: dynamically add/remove authentication and session mgmt methods

Open forgedhallpass opened this issue 2 years ago • 5 comments
trafficstars

  • related PR on ZAP: https://github.com/zaproxy/zaproxy/pull/7857

forgedhallpass avatar May 18 '23 21:05 forgedhallpass

@thc202 this is not WIP, because the work is done. I have tested it locally.

The builds are failing, because these changes are dependent on the PR referenced in the description, hence the initial title "integration" of those changes from ZAP into this repository.

forgedhallpass avatar May 19 '23 11:05 forgedhallpass

It's WIP, it depends on unreleased core changes.

thc202 avatar May 19 '23 11:05 thc202

It's WIP, it depends on unreleased core changes.

I see, I thought you have some labels to mark PRs that have a dependency. What I meant is that the work is done from my part.

forgedhallpass avatar May 19 '23 11:05 forgedhallpass

We cant merge any changes to zap-extensions that depend on unreleased zaproxy changes. We can get around that using reflection and handling the possibility that someone will be using the current version of the core rather than the unreleased one.

psiinon avatar May 19 '23 11:05 psiinon

That would be safer, since core will start throwing an exception.

thc202 avatar May 19 '23 11:05 thc202