zap-extensions icon indicating copy to clipboard operation
zap-extensions copied to clipboard

Published 20 hours ago • verified publisher icon zaproxy

ascanrules: Beta Promotions WIP

Open kingthorin opened this issue 1 year ago • 8 comments

  • Moved scan rule and unit test classes.
  • Relocated help and Messages.properties content.
  • Updated CHANGELOGs.

Signed-off-by: kingthorin [email protected]

kingthorin avatar Sep 22 '22 12:09 kingthorin

Better release the add-ons before starting with the promotions.

thc202 avatar Sep 22 '22 12:09 thc202

OH oops yes we had talked about that. My bad.

I'll leave this open, hopefully it isn't a nightmare to rebase after releasing.

kingthorin avatar Sep 22 '22 13:09 kingthorin

Rebased & CHANGELOGs tweaked.

kingthorin avatar Sep 22 '22 17:09 kingthorin

Rebased & CHANGELOGs tweaked again.

kingthorin avatar Sep 30 '22 11:09 kingthorin

Ping, can I get some reviews on this so that I can move along with others?

kingthorin avatar Oct 01 '22 18:10 kingthorin

We shouldn't merge until we target 2.12 IMO.

thc202 avatar Oct 01 '22 18:10 thc202

Shall I do the Beta ➡️ Release set as another commit here then?

kingthorin avatar Oct 01 '22 19:10 kingthorin

Worth changing to WIP until it's ready to be merged?

ricekot avatar Oct 03 '22 03:10 ricekot

Arg. I've pushed the beta -> release promotions but it looks like it pulled all of the other commits as well. Guess I need to rebase?

psiinon avatar Oct 18 '22 11:10 psiinon

Hopefully ready for review now 😄

psiinon avatar Oct 18 '22 11:10 psiinon

No, I've got some tidying up still to do...

psiinon avatar Oct 18 '22 11:10 psiinon

Think thats it...

psiinon avatar Oct 18 '22 11:10 psiinon

Missed committing one of the test files, hopefully will work this time..

psiinon avatar Oct 18 '22 11:10 psiinon

Forgot to move the ExtensionPayloader registration, now done.

psiinon avatar Oct 18 '22 14:10 psiinon

Hopefully fixed the conflicts without breaking anything...

psiinon avatar Oct 20 '22 08:10 psiinon

think this is ready for review again...

psiinon avatar Oct 20 '22 09:10 psiinon

All checks passed 😁

psiinon avatar Oct 20 '22 10:10 psiinon

I’ll tackle this in the next few hours, it’s too much for a cell screen 😉

kingthorin avatar Oct 20 '22 11:10 kingthorin

Thank you both!

thc202 avatar Oct 20 '22 15:10 thc202

Fixup or do that at merge?

kingthorin avatar Oct 21 '22 08:10 kingthorin

At merge :)

psiinon avatar Oct 21 '22 08:10 psiinon

Hmmm I can’t approve for some reason. E5944638-D399-4328-97B7-9F2DFB3E0290

kingthorin avatar Oct 21 '22 08:10 kingthorin

You are the author of the PR.

thc202 avatar Oct 21 '22 08:10 thc202

Omg, yup that’s how my week is going….

kingthorin avatar Oct 21 '22 08:10 kingthorin