zap-extensions icon indicating copy to clipboard operation
zap-extensions copied to clipboard

Published 20 hours ago • verified publisher icon zaproxy

Tidy up loggers

Open thc202 opened this issue 2 years ago • 3 comments

Make them private, static, and final. Remove a commented out logger. Update changelogs where needed.

thc202 avatar Jul 26 '22 21:07 thc202

I didn't want to do too many changes, there are others (than the ones being changed) that are not using the expected case, can rename them as well in this PR but will do that for all not just the ones being changed. We just need to decide LOG vs LOGGERthen, I prefer the latter.

thc202 avatar Jul 26 '22 22:07 thc202

If you agree it’s worth doing then I’m good with it being done in this PR and I agree with LOGGER.

kingthorin avatar Jul 27 '22 00:07 kingthorin

I have no real preference between LOG and LOGGER - and agree that consistency is always good 😄

psiinon avatar Jul 27 '22 07:07 psiinon

/poke :wink:

kingthorin avatar Dec 09 '22 11:12 kingthorin

I thought we were waiting for you to change to use LOG or LOGGER? 😉

psiinon avatar Dec 09 '22 11:12 psiinon

Sorry I shoulda been more specific, I was poking @thc202 as it’s his PR 😇

edit: I know you’ve been doing other more important stuff, I was just browsing outstanding PRs 😉

kingthorin avatar Dec 09 '22 11:12 kingthorin

@thc202 want me to tackle the naming?

kingthorin avatar Jan 02 '23 00:01 kingthorin

I will finish this week.

thc202 avatar Jan 03 '23 09:01 thc202

Ok, thanks.

kingthorin avatar Jan 03 '23 11:01 kingthorin

Thanks, will skim it sometime today.

kingthorin avatar Jan 06 '23 13:01 kingthorin

For the record I didn't change the regular expression CodeQL is alerting to.

thc202 avatar Jan 06 '23 13:01 thc202

Will address the conflicts soon.

thc202 avatar Jan 06 '23 14:01 thc202

Still LGTM

kingthorin avatar Jan 10 '23 17:01 kingthorin