zap-extensions icon indicating copy to clipboard operation
zap-extensions copied to clipboard

alertFilters: allow to filter by HTTP method

Open thc202 opened this issue 3 years ago • 5 comments

Allow to specify the method when creating alert filters.

Fix zaproxy/zaproxy#5967.

thc202 avatar Mar 26 '21 17:03 thc202

Is a regex the best option here? In the UI a list might be better - less chance of regex typos/mistakes breaking things...

psiinon avatar Apr 06 '21 11:04 psiinon

With the regular expression you can apply the rule to several methods at once. The user can also create rules from existing alerts which would have the exact method.

thc202 avatar Apr 06 '21 11:04 thc202

I'm all for allowing rules to apply to one or more methods, just not sure a regex is the ideal user control. Wouldnt a multiselect be more user friendly and less error prone? Like in the History filter?

psiinon avatar Apr 06 '21 11:04 psiinon

A multiselect/list would restrict which methods can be added though (History filter does not show all standardised methods, nor custom ones for that matter), so multiselect and free text field?

thc202 avatar Apr 06 '21 12:04 thc202

I support having both, and letting the text field override (or add to) the multi-select.

kingthorin avatar Apr 15 '21 22:04 kingthorin

Should be ready for review.

thc202 avatar May 31 '23 10:05 thc202