action-baseline icon indicating copy to clipboard operation
action-baseline copied to clipboard

Use of non root user, zap options and custom reports dir

Open juanmatias opened this issue 3 years ago • 7 comments

I was trying to use image ictu/zap2docker-weekly with this action. This because I need to login into the site with user and pwd. To accomplish this I changed these:

  • the ability to run the container as a non root user
  • the ability of handling zap parameters in a better way
  • the ability to set a different reports base dir

If no parameters added, the defaults are to use root user, to have an empty string as zap parameters and to user current dir as base for reports.

In the readme it is explained and I added a simple example on how to use the after-mentioned image creating and publishing a report as artifact.

juanmatias avatar Apr 28 '21 15:04 juanmatias

Thank you for the contribution, I'll test this over the weekend.

sshniro avatar Apr 30 '21 07:04 sshniro

@sshniro any news?

kingthorin avatar May 11 '21 16:05 kingthorin

This needs to be rebased to pick the latest changes, also, the commit history should be tidied up (better leave the dist generation in a last commit to make it easier to update).

thc202 avatar May 11 '21 16:05 thc202

The changelog should be updated.

thc202 avatar May 11 '21 16:05 thc202

@thc202 sorry for the late reply, the branch was rebased, conflicts solved and all commits merged into one. Please, let me know what else I can do.

juanmatias avatar Sep 03 '21 20:09 juanmatias

Hi @juanmatias , I was not able to run this previously. Unfortunately, I can test this on Friday only. I will test and update the results. Apart from it, the code LGTM!

sshniro avatar Sep 07 '21 08:09 sshniro

For info the root user is no longer used as per https://github.com/zaproxy/action-baseline/pull/77

psiinon avatar May 23 '22 09:05 psiinon