Zappa
Zappa copied to clipboard
Remove special check for Django<1.7, fix for #1158
Description
Removing a long-obsolete check for Django versions less than 1.7 which made a setup() call that is no longer required.
GitHub Issues
https://github.com/zappa/Zappa/issues/1158
Coverage increased (+0.006%) to 74.069% when pulling 901084a4c9f6322dfe0fd87bfd03c45aeb05ba01 on lucernahealth:remove_django17_check into 8effb635b1a23441dd06e3f6949188bd5839fb90 on zappa:master.
Do I need to write a test to bump coverage back up that .08% or can that check be overridden?
@carlkibler I'm having the same issue in a separate PR. At the moment I don't have access to the coveralls settings, and can't update the threshold.
At the moment, the easiest way to get this merged in is to find and add a testcase for code not yet covered.
@carlkibler can you rebase with the latest master branch? I found out that coveralls isn't a blocker when merging, so that's not an issue.
Rebased to master