zapov

Results 196 comments of zapov

Unbound signatures sounds fine. I would probably just slap `@SupressWarning` there, since it's not really important to me, but anything is fine. It's preferable to use arrays instead of list...

There is a partial guard for that with check for number of digits around the code. But I think I added full guard for that only yesterday (in prepareBuffer)

Yes: https://github.com/ngs-doo/dsl-json/blob/master/library/src/main/java/com/dslplatform/json/DslJson.java#L388

More configs should be fine, there are probably a lot of useful missing configurations.

I'm actually not aware of float examples which lead to wrong result. Do you have any? If I knew of them I would probably already look into it, or added...

Sure, but that will not trigger rounding error in DSL-JSON for floats. It's not that number is parsed into exact double equivalent first, rather after significant number of digits, the...

It would be nice to improve this, I "just" need to find some time to work on it :D

I'm not really fully following what you are trying to do, as it's not clear what JSON and a string means. Is this from the same input? How do you...

I'm still missing some context on what you are doing, but there is a test now which shows such usage: https://github.com/ngs-doo/dsl-json/commit/4412e0a4c2a869b0962bd3889520a304aade834d Hopefully that gets you on track.