email-reply-parser icon indicating copy to clipboard operation
email-reply-parser copied to clipboard

Added more regexs cases for different devices/email providers

Open iamshwin opened this issue 6 years ago • 1 comments

Also improved code formatting.

iamshwin avatar Oct 30 '18 10:10 iamshwin

Heyo @iamshwin! Thanks for contributing. A couple things:

1/ I don't see new tests that verify your regex solves the use cases you're trying to solve for.

2/ Also, I don't think the code formatting is a significant improvement. However, I do think changes can be made. Can you separate the two major changes (1) regex change made (include tests) and (2) the formatting into two PRs? The latter we can discuss and determine a cleaner way to perhaps auto-format code to some standard.

roycehaynes avatar Nov 01 '18 15:11 roycehaynes