Andreas Johansson

Results 37 comments of Andreas Johansson

> And about the API, I think we may need to consider to change to like this: > > ```rust > InputState::new() > .code_editor() // default multi_line: true > .multi_line(false)...

> I'd like to introduce this feature, but we need improve the API design. Updated! This is a much nicer API. Let me know if you want it backwards compatible...

> Notable crash, but this is may not be caused by your changes. > > ``` > ➜ gpui-component git:(single-line-code-editor) RUST_BACKTRACE=1 cargo run -- input > Finished `dev` profile [unoptimized...

> Never mind, I have fixed that. You can read my commit to learn of this detail. Ah, I was just trying it on my Mac and you already fixed...

> I have also updated docs, and enabled auto-merge. > > Thank you for PR. Thanks for all the additional fixes! Sorry I missed some of the editor docs

It works in my app if I remove https://github.com/longbridge/gpui-component/blob/main/crates/ui/src/menu/app_menu_bar.rs#L145-L147 But not in the story crate. I also experimented with updating root to be `impl Into + Focusable` and using this...

This has been resolved with the latest updates