Joshua Clark

Results 57 comments of Joshua Clark

This function is no longer part of PHP 7 so you might be able to just remove it. There are a couple instances in the code https://github.com/lirantal/daloradius/search?utf8=%E2%9C%93&q=set_magic_quotes_runtime&type=Code Also, `get_magic_quotes_runtime` should...

You should be able to wrap those with `function_exists` ```php if (function_exists('set_magic_quotes_runtime')) { set_magic_quotes_runtime($value); } ```

Ah, I see. I didn't realize these were 3rd party libraries.

Ran it through the conversion tool and here are the suggestions it returns ``` manifest.json  .author : String is too short (0 chars), minimum 1 appxManifest.xml Replace INSERT-YOUR-PACKAGE-PROPERTIES-PUBLISHERDISPLAYNAME-HERE with the...

I don't know if the devs are looking into this or not. As for me, I haven't had time to look further into this, but I will once I get...

That is quite disappointing.

It might be a good idea to have your edits on a fork so the devs have an easier way to see your edits.

> > Ran it through the conversion tool and here are the suggestions it returns > > ``` > > manifest.json  .author : String is too short (0 chars), minimum...

~The overflow issue is still present for me on HA 2022.12~ Nevermind, the fix is in v1.8 ![image](https://user-images.githubusercontent.com/1580378/210487284-720f0e8c-fc4e-4003-89af-546e344cf89f.png) ![image](https://user-images.githubusercontent.com/1580378/210487420-350d0246-1792-4db1-82f2-b8bb3e7a6801.png)

Ah, I see my fix was added to v1.8