Zanie Blue

Results 2930 comments of Zanie Blue

@kpweiler no, this would be available as a sync and async interface.

The ecosystem checks look good to me, except the FastAPI ones which are... hard to comment on. I'm not sure if they can use this rule? I'd gate this with...

@sckott do you just mean toggling `stream_output` to `False`? https://github.com/PrefectHQ/prefect-shell/blob/main/prefect_shell/commands.py#L234

I see so you're just interested in dropping the "PID ... stream output:" prefix from the logs?

It's hard-coded at https://github.com/PrefectHQ/prefect-shell/blob/main/prefect_shell/commands.py#L160 I'd review a pull request making that prefix optional. Perhaps `stream_output_include_pid: bool = True`. Another option is to get a _child_ logger for each stream output...

@sckott if we use a child logger with the PID in the name (in the code I linked) we can drop the prefix entirely as the information would be encoded...

A change in `prefect-shell`. The logs would just include the output from the command. The pid would be included in the logger name.

The PID would appear in local logs, ~but the logger name is not exposed in the UI at this time~ we're adding logger names in the UI in https://github.com/PrefectHQ/prefect-ui-library/pull/1203

Lots to consider here, I'll just link some related topics to start: - https://github.com/astral-sh/uv/issues/1855 - https://github.com/astral-sh/uv/issues/1497 - https://github.com/astral-sh/uv/pull/2430 - https://github.com/astral-sh/uv/pull/2471 - https://github.com/astral-sh/uv/issues/2310 - https://github.com/astral-sh/uv/issues/171

Let me know if you want my review.